Update rustbuild README #44014
Merged
Update rustbuild README #44014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: r+ rollup |
|
📌 Commit 1db158d has been approved by |
| * Adding a new configuration option? Take a look at `bootstrap/config.rs` or | ||
| perhaps `bootstrap/flags.rs` and then modify the build elsewhere to read that | ||
| option. | ||
| * Adding a new dependency from crates.io? This should just work inside the |
There was a problem hiding this comment.
Should we document things regarding proc macros? (As they're plugins, they still cannot be used inside compiler)
There was a problem hiding this comment.
I'd be happy to accept a PR for this.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 22, 2017
…excrichton Update rustbuild README Fixes rust-lang#44007. r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44007.
r? @alexcrichton